Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update quarantine for build with no optimization #13598

Closed
wants to merge 1 commit into from

Conversation

PerMac
Copy link
Contributor

@PerMac PerMac commented Jan 12, 2024

Due to a failure of unity.nrf91_sockets_test test

Due to a failure of unity.nrf91_sockets_test test

Signed-off-by: Maciej Perkowski <[email protected]>
@PerMac PerMac requested review from tejlmand and a team as code owners January 12, 2024 11:44
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 12, 2024
@PerMac
Copy link
Contributor Author

PerMac commented Jan 12, 2024

The test is failing when no optimizations are turned on:

../zephyr/scripts/twister -T tests/lib/nrf_modem_lib --no-detailed-test-id -s unity.nrf91_sockets_test -v -p native_posix --extra-args CONFIG_NO_OPTIMIZATIONS=y

@MirkoCovizzi you are mentioned as a codeowner of this area. Will you take a look at this failure? A fix can come with clearing the quarantine file

@NordicBuilder
Copy link
Contributor

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@balaji-srin balaji-srin removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 12, 2024
@MirkoCovizzi
Copy link
Contributor

MirkoCovizzi commented Jan 12, 2024

The test is failing when no optimizations are turned on:

../zephyr/scripts/twister -T tests/lib/nrf_modem_lib --no-detailed-test-id -s unity.nrf91_sockets_test -v -p native_posix --extra-args CONFIG_NO_OPTIMIZATIONS=y

@MirkoCovizzi you are mentioned as a codeowner of this area. Will you take a look at this failure? A fix can come with clearing the quarantine file

I'm taking a look.

Edit:

Found the bug, opened a PR with a fix here: zephyrproject-rtos/zephyr#67559

@MirkoCovizzi
Copy link
Contributor

MirkoCovizzi commented Jan 16, 2024

@PerMac Made a PR with the fix here #13623

@MirkoCovizzi
Copy link
Contributor

@PerMac This PR can now be closed as afa47cd fixes the issue.

@PerMac PerMac closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants