Compliance

caf: leds: Improvements to LED effects #82660

Triggered via pull request January 20, 2025 15:46

nrbrook

synchronize #19904

nrbrook:feature/improve_cad_leds2

Status Failure

Total duration 1m 50s

Artifacts 1

compliance.yml

on: pull_request

Run compliance checks on patch series (PR)

1m 43s

Annotations

14 errors and 10 warnings

Run compliance checks on patch series (PR): KconfigBasic.txt#L1

See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details. /home/runner/work/sdk-nrf/sdk-nrf/ncs/nrf/subsys/caf/modules/Kconfig.leds:49: error: couldn't parse 'bool "Log verbose debug messages that may be printed out very frequently (perhaps several per': unterminated string

Run compliance checks on patch series (PR): Checkpatch.txt#L1

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. LONG_LINE: line length of 121 exceeds 100 columns File:include/caf/led_effect.h Line:66 LONG_LINE: line length of 196 exceeds 100 columns File:include/caf/led_effect.h Line:67 LONG_LINE: line length of 164 exceeds 100 columns File:include/caf/led_effect.h Line:68 LONG_LINE: line length of 164 exceeds 100 columns File:include/caf/led_effect.h Line:69 LONG_LINE: line length of 164 exceeds 100 columns File:include/caf/led_effect.h Line:70 SPACE_BEFORE_TAB: please, no space before tabs File:include/caf/led_effect.h Line:70 SPACE_BEFORE_TAB: please, no space before tabs File:include/caf/led_effect.h Line:73 LONG_LINE: line length of 156 exceeds 100 columns File:include/caf/led_effect.h Line:82 LONG_LINE: line length of 164 exceeds 100 columns File:include/caf/led_effect.h Line:84 LONG_LINE: line length of 172 exceeds 100 columns File:include/caf/led_effect.h Line:85 LONG_LINE: line length of 148 exceeds 100 columns File:include/caf/led_effect.h Line:86 LONG_LINE: line length of 156 exceeds 100 columns File:include/caf/led_effect.h Line:88 LONG_LINE: line length of 140 exceeds 100 columns File:include/caf/led_effect.h Line:89 LONG_LINE: line length of 148 exceeds 100 columns File:include/caf/led_effect.h Line:90 LONG_LINE: line length of 156 exceeds 100 columns File:include/caf/led_effect.h Line:92 LONG_LINE: line length of 140 exceeds 100 columns File:include/caf/led_effect.h Line:93 LONG_LINE: line length of 156 exceeds 100 columns File:include/caf/led_effect.h Line:95 LONG_LINE: line length of 140 exceeds 100 columns File:include/caf/led_effect.h Line:96 LONG_LINE: line length of 148 exceeds 100 columns File:include/caf/led_effect.h Line:97 LONG_LINE: line length of 146 exceeds 100 columns File:include/caf/led_effect.h Line:177 LONG_LINE: line length of 187 exceeds 100 columns File:include/caf/led_effect.h Line:178 LONG_LINE: line length of 131 exceeds 100 columns File:include/caf/led_effect.h Line:179 LONG_LINE: line length of 170 exceeds 100 columns File:include/caf/led_effect.h Line:180 LONG_LINE: line length of 139 exceeds 100 columns File:include/caf/led_effect.h Line:181 LONG_LINE: line length of 172 exceeds 100 columns File:include/caf/led_effect.h Line:182 LONG_LINE: line length of 146 exceeds 100 columns File:include/caf/led_effect.h Line:197 LONG_LINE: line length of 187 exceeds 100 columns File:include/caf/led_effect.h Line:198 LONG_LINE: line length of 130 exceeds 100 columns File:include/caf/led_effect.h Line:199 LONG_LINE: line length of 121 exceeds 100 columns File:include/caf/led_effect.h Line:200 LONG_LINE: line length of 179 exceeds 100 columns File:include/caf/led_effect.h Line:201 LONG_LINE: line length of 153 exceeds 100 columns File:include/caf/led_effect.h Line:217 LONG_LINE: line length of 187 exceeds 100 columns File:include/caf/led_effect.h Line:218 LONG_LINE: line length of 129 exceeds 100 columns File:include/caf/led_effect.h Line:219 LONG_LINE: line length of 164 exceeds 100 columns File:include/caf/led_effect.h Line:220 LONG_LINE: line length of 153 exceeds 100 columns File:include/caf/led_effect.h Line:221 LONG_LINE: line length of 172 exceeds 100 columns File:include/caf/led_effect.h Line:222 LONG_LINE: line length of 145 exceeds 100 columns File:include/caf/led_effect.h Line:247 LONG_LINE: line length of 140 exceeds 100 columns File:include/caf/led_effect.h Line:259 LONG_LINE: line length of 172 exceeds 100 columns File:include/caf/led_effect.h Line:260 LONG_LINE: line length of 138 exceeds 100 columns File:include/caf/led_effect.h Line:261 LONG_LINE: line length of 131 exceeds 100 columns File:include/caf/led_effect.h Line:269 LONG_LINE: line length of 130 exceeds 100 columns File:include/caf/led_effect.h Line:270 LONG_LINE: line length of 130 exceeds 100 columns File:include/caf/led_effect.h Line:277 LONG_LINE: line length of 130 exceeds 100 columns File:include/caf/led_effect.h Line:284 LONG_LINE: line length of 139 exceeds 100 columns File:incl

Run compliance checks on patch series (PR): GitDiffCheck.txt#L1

Git conflict markers and whitespace errors are not allowed in added changes df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:102: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:107: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:109: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:113: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:115: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:122: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:139: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:152: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:156: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:164: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:166: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:170: trailing whitespace. df6202b473db4f46df4b72b8d323f58c9f535f4a: subsys/caf/modules/leds.c:172: trailing whitespace.

Run compliance checks on patch series (PR)

Process completed with exit code 1.

SPACING: include/caf/led_effect.h#L412

include/caf/led_effect.h:412 space prohibited before that close parenthesis ')'

SPACING: include/caf/led_effect.h#L562

include/caf/led_effect.h:562 space prohibited before that close parenthesis ')'

C99_COMMENTS: subsys/caf/modules/leds.c#L83

subsys/caf/modules/leds.c:83 do not use C99 // comments

OPEN_BRACE: subsys/caf/modules/leds.c#L85

subsys/caf/modules/leds.c:85 open brace '{' following function definitions go on the next line

SPACING: subsys/caf/modules/leds.c#L89

subsys/caf/modules/leds.c:89 space prohibited after that open parenthesis '('