samples: cellular: nrf_cloud_ble_gateway: New sample #82027
Annotations
14 errors and 10 warnings
|
check-warns:
Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Please remove blank lines at end of 'samples/cellular/nrf_cloud_ble_gateway/boards/nrf9160dk_nrf9160_ns_0_14_0.overlay'
Please remove blank lines at end of 'samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst'
|
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:452
BLOCK_COMMENT_STYLE: Block comments should align the * on each line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1340
SPACE_BEFORE_TAB: please, no space before tabs
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1382
SPACE_BEFORE_TAB: please, no space before tabs
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1384
SPACE_BEFORE_TAB: please, no space before tabs
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1386
SPACE_BEFORE_TAB: please, no space before tabs
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1388
SPACE_BEFORE_TAB: please, no space before tabs
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c
Line:1586
OPEN_BRACE: open brace '{' following enum go on the same line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:75
PREFER_PACKED: __packed is preferred over __attribute__((packed))
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:128
OPEN_BRACE: open brace '{' following enum go on the same line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:131
OPEN_BRACE: open brace '{' following enum go on the same line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:139
PREFER_PACKED: __packed is preferred over __attribute__((packed))
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:153
ELSE_AFTER_BRACE: else should follow close brace '}'
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:240
UNNECESSARY_ELSE: else is not generally useful after a break or return
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:388
INITIALISED_STATIC: do not initialise statics to 0
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:857
INITIALISED_STATIC: do not initialise statics to 0
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:858
INITIALISED_STATIC: do not initialise statics to 0
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:859
ELSE_AFTER_BRACE: else should follow close brace '}'
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:1086
LINE_SPACING: Missing a blank line after declarations
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:1172
IF_0: Consider removing the code enclosed by this #if 0 and its #endif
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c
Line:1369
BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c
Line:29
BLOCK_COMMENT_STYLE: Block comments should align the * on each line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c
Line:29
SPACING: spaces required around that '=' (ctx:VxW)
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c
Line:120
LINE_SPACING: Missing a blank line after declarations
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/gateway.c
Line:97
OPEN_BRACE: open brace '{' following enum go on the same line
File:samples/cellular/nrf_cloud_ble_gateway/src/ble/ui/include/ui.h
Line:101
TYPO_SPELLING: 'triggerd' may be misspelled - perhaps 'triggered'?
File:samples/cellular/nrf_cloud_ble_gateway/src/cloud_connection.c
Line:176
POINTER_LOCATION: "foo * bar" should be "foo *bar"
File:samples/cellular/nrf_cloud_ble_gateway/src/fota_support.c
Line:20
POINTER_LOCATION: "foo * bar" should be "foo *bar"
File:samples/cellular/nrf_cloud_ble_gateway/src/fota_support.h
Line:34
TYPO_SPELLING: 'enqueing' may be misspelled - perhaps 'enqueuing'?
File:samples/cellular/nrf_cloud_ble_gateway/src/message_queue.c
Line:22
LEADING_SPACE: please, no space
|
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/boards/arm/apricity_gateway_nrf9160/nrf52840_reset.c:245: new blank line at EOF.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/boards/nrf9160dk_nrf9160_ns_0_14_0.overlay:26: new blank line at EOF.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:57: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:137: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:138: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:267: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:309: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:332: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:341: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:346: space before tab in indent.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:355: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:373: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:376: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:377: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:399: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/README.rst:513: new blank line at EOF.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/ble.c:100: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/ble.c:351: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/ble_codec.c:502: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/ble_codec.c:1315: new blank line at EOF.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:1216: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:1218: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c:23: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/gateway.c:644: trailing whitespace.
fe0e942ebecaa6620723aa72a8f09a3bc31104b2: samples/cellular/nrf_cloud_ble_gateway/src/ble/gateway.c:691: new blank line at EOF.
|
|
check-warns
Process completed with exit code 1.
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L75
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:75 open brace '{' following enum go on the same line
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L131
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:131 open brace '{' following enum go on the same line
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L139
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:139 open brace '{' following enum go on the same line
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L240
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:240 else should follow close brace '}'
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L857
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:857 do not initialise statics to 0
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L858
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:858 do not initialise statics to 0
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L859
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:859 do not initialise statics to 0
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L1086
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:1086 else should follow close brace '}'
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c#L120
samples/cellular/nrf_cloud_ble_gateway/src/ble/flash/flash_test.c:120 spaces required around that '=' (ctx:VxW)
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/ui/include/ui.h#L101
samples/cellular/nrf_cloud_ble_gateway/src/ble/ui/include/ui.h:101 open brace '{' following enum go on the same line
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L452
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:452 static const char * array should probably be static const char * const
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1340
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1340 Block comments should align the * on each line
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1382
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1382 please, no space before tabs
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1384
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1384 please, no space before tabs
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1386
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1386 please, no space before tabs
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1388
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1388 please, no space before tabs
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c#L1586
samples/cellular/nrf_cloud_ble_gateway/src/ble/cli.c:1586 please, no space before tabs
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L128
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:128 __packed is preferred over __attribute__((packed))
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L153
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:153 __packed is preferred over __attribute__((packed))
|
|
Run Compliance Tests:
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c#L388
samples/cellular/nrf_cloud_ble_gateway/src/ble/dfu/peripheral_dfu.c:388 else is not generally useful after a break or return
|
Loading