Fix Fail-Safe after reboot #559
Draft
+243
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adigie
commented
Feb 25, 2025
adigie
commented
- Add Fail-Safe marker and store it before adding/updating NOC.
- Check if marker is present in settings during boot.
- Delete all Fabric data, even if they are not complete.
Commit marker was moved from FailSafeContext to FabricTable in #20010, however name of the key wasn't changed and it's misleading. This commit changes the name of the method returning commit marker key, but keeps the key name for backward compatibility. Signed-off-by: Adrian Gielniewski <[email protected]>
CommitToStorage was removed in #20010. Signed-off-by: Adrian Gielniewski <[email protected]>
FailSafeContext needs storage for marker. Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Add cleanup parameter that indicates if FabricTable should try to cleanup all fabric data regardless if fabric was initialized. Signed-off-by: Adrian Gielniewski <[email protected]>
Cleanup all (even when incomplete) fabric data. Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Signed-off-by: Adrian Gielniewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.