config: Add initial sysbuild files #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
| @@ -244,7 +244,7 @@ endif() | |||
| # Define 'factory_data' target for generating a factory data partition | |||
| # ============================================================================== | |||
|
|
|||
| if (CONFIG_CHIP_FACTORY_DATA_BUILD) | |||
| if(CONFIG_CHIP_FACTORY_DATA_BUILD AND NOT SYSBUILD) | |||
There was a problem hiding this comment.
Why skipping factory data when using sysbuild? Is it because of WIP?
There was a problem hiding this comment.
sysbuild code is in the other file
There was a problem hiding this comment.
Ok, I see the new file is used in sysbuild CMake.
ArekBalysNordic
requested changes
May 14, 2024
config/nrfconnect/chip-module/generate_factory_data_sysbuild.cmake
Outdated
Show resolved
Hide resolved
nordicjm
force-pushed
the
sysbuild
branch
4 times, most recently
from
5f09430 to
03affd5
Compare
|
Rebased PR to pull Matter 1.3 |
ArekBalysNordic
approved these changes
May 17, 2024
markaj-nordic
approved these changes
May 20, 2024
Adds initial sysbuild files Signed-off-by: Jamie McCrae <[email protected]>
Converted matter-ota.cmake script to sysbuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial WIP sysbuild files