[nrf noup] Lock thread stack before factory reset #380
Conversation
LipinskiPNordicSemi
force-pushed
the
factory_reset_fail
branch
2 times, most recently
from
1bd8078 to
4406491
Compare
| @@ -176,6 +176,7 @@ void ConfigurationManagerImpl::RunConfigUnitTest(void) | |||
| void ConfigurationManagerImpl::DoFactoryReset(intptr_t arg) | |||
| { | |||
| ChipLogProgress(DeviceLayer, "Performing factory reset"); | |||
| ThreadStackManager().LockThreadStack(); | |||
There was a problem hiding this comment.
This probably won't compile (?)
| ThreadStackManager().LockThreadStack(); | |
| ThreadStackMgr().LockThreadStack(); |
Also, do not assume it's Matter over Thread.
There was a problem hiding this comment.
@Damian-Nordic Is there any Matter api which allow to disable thread?
There was a problem hiding this comment.
Not sure I understand, I meant that you should compile this line only if CONFIG_NET_L2_OPENTHREAD is defined as it may not compile for Wi-Fi.
There was a problem hiding this comment.
Btw. you could add a comment explaining why this is needed as Lock without Unlock can look weird to newcomers :).
LipinskiPNordicSemi
force-pushed
the
factory_reset_fail
branch
from
4406491 to
24d13ec
Compare
| @@ -176,6 +176,7 @@ void ConfigurationManagerImpl::RunConfigUnitTest(void) | |||
| void ConfigurationManagerImpl::DoFactoryReset(intptr_t arg) | |||
| { | |||
| ChipLogProgress(DeviceLayer, "Performing factory reset"); | |||
| ThreadStackMgr().LockThreadStack(); | |||
There was a problem hiding this comment.
This must be guarded with #ifdef CONFIG_NET_L2_OPENTHREAD
| ThreadStackMgr().LockThreadStack(); | |
| #ifdef CONFIG_NET_L2_OPENTHREAD | |
| ThreadStackMgr().LockThreadStack(); | |
| #endif |
Also, as Damian suggested, please describe what is the purpose of this call here and why it can be used here without unlocking the stack.
doublemis1
force-pushed
the
factory_reset_fail
branch
from
24d13ec to
99cfd7a
Compare
doublemis1
force-pushed
the
factory_reset_fail
branch
from
81f580e to
7570c0d
Compare
doublemis1
force-pushed
the
factory_reset_fail
branch
from
7570c0d to
fd65228
Compare
This commit fix a problem with thread activity interrupting factory reset. This activity used to led to “Factory reset fail: -6”. Writing to cleared nvm flash pages caused the problem. Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]>
doublemis1
force-pushed
the
factory_reset_fail
branch
from
fd65228 to
4d80d20
Compare
This commit fix a problem with thread activity interrupting factory reset. This activity used to led to “Factory reset fail: -6”. Writing to cleared nvm flash pages caused the problem.