This repository has been archived by the owner on Mar 21, 2020. It is now read-only.
Using localhost doesn't work: 127.0.0.1 is required #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Syringe endpoint on localhost:8086 is only detected based on URL containing 127.0.0.1, not localhost. Hence an explicit IP instead.
olberger
added a commit
to olberger/antidote-web
that referenced
this pull request
Nov 4, 2019
Allows URL to be http://localhost:8080/ and still use syringe on 8086 Once merged, nre-learning/antidote#70 is either no longer needed, or should be reverted. Note that this doesn't work for IPv6-style local address, etc. :-/
|
If nre-learning/antidote-web#84 is applied, this is no longer necessary |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Syringe endpoint on localhost:8086 is only detected based on URL containing 127.0.0.1, not localhost.
Hence an explicit IP instead.