Fix #1018: Number of brems events miscounted for DBS in BEAMnrc

[rtownson]

Fix the output message in the egslst file for BEAMnrc simulations about the number of brems events the took place. When DBS was turned on, it would always read zero.

Just to be clear, there was nothing wrong with the splitting or the simulation. This is just a small bug in the counter variable that is only used to print to the egslst file.

@blakewalters please double check this change.

[ftessier]

@blakewalters please double-check this pull request for merging.

[ftessier]

• Checked that NUM_BREM is only ever used for information output, and nothing else

[blakewalters]

@rtownson: Please see my question above about possible miscounts when BCSE is used. Thanks!

[rtownson]

@rtownson: Please see my question above about possible miscounts when BCSE is used. Thanks!

I'm not seeing this question, could you give a link?

[blakewalters]

@rtownson: See the comment in https://github.com/nrc-cnrc/EGSnrc/pull/1019/files

[rtownson]

@rtownson: See the comment in https://github.com/nrc-cnrc/EGSnrc/pull/1019/files

@blakewalters strange, there's no comment there for me.. I guess just repeat it here!

[blakewalters]

@rtownson, with reference to line 6426 of beamnrc.mortran: It looks like there could be a miscount in the case of bcse, where by this point in the logic nbr_split has been set back to nbrspl_orgnl (i.e. the input value of nbrspl). I think it would be okay to set NUM_BREM=count_nbrem, which is already keeping track of brem events for DBS, on this line, though. Whaddya think?

[ftessier]

@blakewalters there is no comment, but you might see it if you have not clicked on "submit single comment" (or "start a review). If the comment does not show up in the conversation thread, then it has not been registered, so to speak.

[rtownson]

Thanks for catching that Blake, I've fixed it as per your suggestion so it will work for BCSE as well.

[ftessier]

Great catch @blakewalters 🏅!