Deprecation in common.py: #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y 1.8. Replaced it with .wkt
npucino
reviewed
Dec 12, 2024
|
I will wait for the new PR with the updated .yml file for cross-platform compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.to_wkt() is deprecated since around shapely 1.8. Replaced it with .wkt.
This is not only important for future proofing, but also because the original sandpyper dependency requirements and suggested virtual environment and package versions create so many conflicts when installing SP with conda on a Mac, that it makes Sandpyper unusable.
I will make another Branch that deals with Sandpyper's cross-platform usability and share an environment .yml file with dependencies that do work on a Mac, and which uses a more recent version of some packages like shapely, thus making this fix unavoidable.