Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undeprecate / dry-run #8009

Merged
merged 2 commits into from
Jan 6, 2025
Merged

undeprecate / dry-run #8009

merged 2 commits into from
Jan 6, 2025

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jan 3, 2025

Adds undeprecate command, adds logging info to output, and adds dry-run to deprecate and undeprecate

Closes: npm/statusboard#376

example of deperecate in dry-run mode showing new notice log messages

example of undeprecate in dry-run mode showing new notice log messages

example of deprecate with an empty message still logging undeprecate log messages

@wraithgar wraithgar requested a review from a team as a code owner January 3, 2025 18:08
@ljharb
Copy link
Contributor

ljharb commented Jan 3, 2025

nice, is this just sugar for deprecate with an empty string?

@wraithgar wraithgar force-pushed the gar/undeprecate branch 2 times, most recently from 988fbc4 to d5ead63 Compare January 3, 2025 18:33
@wraithgar
Copy link
Member Author

wraithgar commented Jan 3, 2025

nice, is this just sugar for deprecate with an empty string?

Yes, because npm deprecate pkg '' technically works but it's not a great experience.

@wraithgar
Copy link
Member Author

That logging could get very noisy if doing a LOT of versions.

lib/commands/deprecate.js Show resolved Hide resolved
@wraithgar wraithgar merged commit 7f6c997 into latest Jan 6, 2025
38 checks passed
@wraithgar wraithgar deleted the gar/undeprecate branch January 6, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm undeprecate
3 participants