Skip to content

ci: add homebrew action and docs #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 10, 2024
Merged

ci: add homebrew action and docs #735

merged 3 commits into from
Nov 10, 2024
+27 −1

Conversation

nitrocode
Copy link

@nitrocode nitrocode commented Oct 28, 2024 •
edited
Loading

what

  • Add homebrew update action
  • Add homebrew install instructions

why

  • Show the community that action-docs is even easier to install on osx
  • Keep the formula up to date

references

@nitrocode nitrocode changed the title Homebrew ci: add homebrew action and docs Oct 28, 2024
@nitrocode nitrocode marked this pull request as ready for review October 29, 2024 16:45
@nitrocode nitrocode mentioned this pull request Oct 29, 2024
Open
@nitrocode
Copy link
Author

@npalm please review

@nitrocode
fix: address feedback
Loading
Loading status checks…
4c64767
@nitrocode nitrocode requested a review from npalm October 30, 2024 20:21
npalm
npalm requested changes Nov 1, 2024
View reviewed changes
Copy link
Owner

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, loooks good, but I think the action needs some adjustments. Did you tried running the action on a fork? In that case can you link the worfklow run?

.github/workflows/release.yml
runs-on: ubuntu-latest
needs: release
steps:
- uses: mislav/bump-homebrew-formula-action@b3327118b2153c82da63fd9cbf58942146ee99f0 # v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the action on a branch with the release? Looking at the docs, I think we should set tag-name with the output of the release.

.github/workflows/release.yml
formula-name: action-docs
formula-path: Formula/a/action-docs.rb
env:
COMMITTER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won't work, it seems a PAT token is required here bacause as far I understand the token is used to open the PR or commit code to a PR. The GitHub token can't do that. It can only act in repo scop.

@npalm npalm changed the base branch from main to npalm/homebrew November 10, 2024 09:47
@npalm
Copy link
Owner

npalm commented Nov 10, 2024

@nitrocode thanks, will merge the PR in an own branch to setup secrets and get it working.

@npalm npalm merged commit 1a2ab40 into npalm:npalm/homebrew Nov 10, 2024
5 checks passed
@npalm
Copy link
Owner

npalm commented Nov 10, 2024

@nitrocode tried the action, but did not got it working.

See https://github.com/npalm/action-docs/actions/runs/11764234621/job/32769405768

I get an unexpected 401. The token has repo and workflow acces. Any clue what the problem could be?

npalm pushed a commit that referenced this pull request Nov 10, 2024
@nitrocode @npalm
ci: add homebrew action and docs (#735)
ccc0e80 
* ci: add homebrew step

* docs: add brew install

* fix: address feedback
@npalm
Copy link
Owner

npalm commented Nov 10, 2024

Moved the work to this PR, got it working

#744

@nitrocode nitrocode deleted the homebrew branch November 13, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homebrew formula for action-docs
2 participants
@nitrocode @npalm