Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web, dashboard): replace BridgeStatus type with HealthCheck type, provide state for preview #6910

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Nov 10, 2024

What changed? Why was the change needed?

  • Web
    • Pass required state array to Bridge API endpoint when rendering preview
    • Add simple not found page when visiting invalid Studio workflow
    • Use Framework typings for Bridge API client + hooks
  • Dashboard
    • Use Framework types for Bridge health check component

Screenshots

Before: Framework expected state and resulted in this error with latest Framework changes when previewing a non-first step
image

After: no runtime state error shown when previewing non-first step
image

Before - Visiting a URL for an invalid workflow was an uncaught exception
image

After - Added simple not found page in Local Studio to prevent runtime error
image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 788501e
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67311e6a8094f800087d8718
😎 Deploy Preview https://deploy-preview-6910--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rifont rifont requested review from SokratisVidros and LetItRock and removed request for LetItRock November 10, 2024 20:58
@rifont rifont changed the title fix(web, dashboard): replace BridgeStatus with HealthCheck, fix state fix(web, dashboard): replace BridgeStatus type with HealthCheck type, provide state for preview Nov 10, 2024
Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

apps/dashboard/src/utils/types.ts Show resolved Hide resolved
@rifont rifont merged commit ebb999b into next Nov 11, 2024
43 checks passed
@rifont rifont deleted the fix-local-studio-state-error branch November 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants