-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): Add onesignal push provider new api #6794
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for novu-stg-vite-dashboard-poc pending review.Visit the deploys page to approve it
|
suplere
changed the title
Add onesignal push provider new api
feat: Add onesignal push provider new api
Oct 29, 2024
suplere
changed the title
feat: Add onesignal push provider new api
feat(providers): Add onesignal push provider new api
Oct 29, 2024
Could you someone have a look on this new implementation Onesignal API? |
@scopsy any chance you could take a look at this? Would also fix our problem that prevents us from going live after our big refactor. Thanks! |
@suplere why did you close the MR? |
@L-U-C-K-Y there is another MR open by @suplere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This provider is by new Onesignal recommendation - new user model API. Here is the doc from Onesignal web.
This provider not replace existing player based Onesignal provider, but add new which use last Onesignal user model api.
Screenshots
Here is link for example GitHub repository - you can see how you can manage OneSignal external UserID, add this to NOVU subscribers, and send some test Push message.
novu-onesignal-nextjs
Related enterprise PR
Special notes for your reviewer
This provider not replace existing player based Onesignal provider, but add new which use last Onesignal user model api.