Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): Add onesignal push provider new api #6794

Closed
wants to merge 9 commits into from

Conversation

suplere
Copy link

@suplere suplere commented Oct 29, 2024

What changed? Why was the change needed?

This provider is by new Onesignal recommendation - new user model API. Here is the doc from Onesignal web.

This provider not replace existing player based Onesignal provider, but add new which use last Onesignal user model api.

Screenshots

User si subscribed and set External ID from application database (at most cases). When is External Id set on Onesignal providers - via this methods: ` include_aliases: { external_id: options.target, } `

Here is link for example GitHub repository - you can see how you can manage OneSignal external UserID, add this to NOVU subscribers, and send some test Push message.

novu-onesignal-nextjs

Related enterprise PR

Special notes for your reviewer

This provider not replace existing player based Onesignal provider, but add new which use last Onesignal user model api.

Copy link

netlify bot commented Oct 29, 2024

👷 Deploy request for novu-stg-vite-dashboard-poc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3946ddb

@suplere suplere changed the title Add onesignal push provider new api feat: Add onesignal push provider new api Oct 29, 2024
@suplere suplere changed the title feat: Add onesignal push provider new api feat(providers): Add onesignal push provider new api Oct 29, 2024
@suplere
Copy link
Author

suplere commented Nov 10, 2024

Could you someone have a look on this new implementation Onesignal API?

@L-U-C-K-Y
Copy link
Contributor

@scopsy any chance you could take a look at this? Would also fix our problem that prevents us from going live after our big refactor.

Thanks!

@suplere suplere closed this by deleting the head repository Nov 12, 2024
@L-U-C-K-Y
Copy link
Contributor

@suplere why did you close the MR?

@scopsy
Copy link
Contributor

scopsy commented Nov 13, 2024

@L-U-C-K-Y there is another MR open by @suplere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants