Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #56

Merged
merged 26 commits into from
Jul 23, 2024
Merged

Improve documentation #56

merged 26 commits into from
Jul 23, 2024

Conversation

Brian-Pho
Copy link
Collaborator

Improves the documentation process and content

@Brian-Pho Brian-Pho self-assigned this Jul 8, 2024
@Brian-Pho Brian-Pho requested a review from rldoris July 9, 2024 16:37
@valgur
Copy link
Contributor

valgur commented Jul 10, 2024

Regarding the Conan dependency, it can be made optional with these additions to conan_provider.cmake: conan-io/cmake-conan#651
That way you can basically simply do cmake . -B build && cmake --build build.
Should I open a PR?

@Brian-Pho
Copy link
Collaborator Author

Regarding the Conan dependency, it can be made optional with these additions to conan_provider.cmake: conan-io/cmake-conan#651 That way you can basically simply do cmake . -B build && cmake --build build. Should I open a PR?

If you can, yes please. But for now installing conan via pip is fine too.

@Brian-Pho Brian-Pho marked this pull request as ready for review July 12, 2024 15:31
@Brian-Pho Brian-Pho merged commit c6ad383 into main Jul 23, 2024
30 checks passed
@Brian-Pho Brian-Pho deleted the dev-bpho-improve_documentation branch July 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants