Rebase on current biocad master #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow base-compat-batteries 0.13
Allow hspec 2.11
Allow aeson 2.2
Give title to sub-schemas of oneOf for sum types
Bump versions for GHC 9.8
Not particularly useful until `insert-ordered-containers` does so too, see phadej/insert-ordered-containers#58
Not especially useful until dependencies catch up, see: * haskell/aeson#1096 * haskellari/qc-instances#92
Allow cookie-0.5
While checking my generated openapi spec with https://editor.swagger.io/ I had errors like: Semantic error at components.schemas.BaselineCheck_'HasCase_PhysicalUnit Component names can only contain the characters A-Z a-z 0-9 - . _ Looking at the spec: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#components-object This looked like a valid concern: `name must conform to ^[a-zA-Z0-9\.\-_]+$` This replaces invalid characters by their code.
Workaround for biocad#31 If the tuples has homogeneous types, the generated schema is strict. On the other hand if there are heterogeneous types, the schema is not very strict because the order in which the types must come is not specified. Also, I had to use anyOf instead of oneOf because for example the int in (Int, Float) matches both Integer and Number. Finally, special care had to be taken to handle nullables.
Rebase forked lib on current biocad master
|
@teto is it good to merge? |
Not particularly useful until `insert-ordered-containers` does so too, see phadej/insert-ordered-containers#58
Not especially useful until dependencies catch up, see: * haskell/aeson#1096 * haskellari/qc-instances#92
Resolve conflicts
While checking my generated openapi spec with https://editor.swagger.io/ I had errors like: Semantic error at components.schemas.BaselineCheck_'HasCase_PhysicalUnit Component names can only contain the characters A-Z a-z 0-9 - . _ Looking at the spec: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#components-object This looked like a valid concern: `name must conform to ^[a-zA-Z0-9\.\-_]+$` This replaces invalid characters by their code.
Workaround for biocad#31 If the tuples has homogeneous types, the generated schema is strict. On the other hand if there are heterogeneous types, the schema is not very strict because the order in which the types must come is not specified. Also, I had to use anyOf instead of oneOf because for example the int in (Int, Float) matches both Integer and Number. Finally, special care had to be taken to handle nullables.
Rebase on current biocad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at getting the commits pushed since March 13, 2023 into our master repo