Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Expose space open/closed status for RSS feed #4

Merged
merged 2 commits into from
Jun 3, 2012
Merged

Enhancement: Expose space open/closed status for RSS feed #4

merged 2 commits into from
Jun 3, 2012

Conversation

warewolf
Copy link
Contributor

Two commits here:

  • warewolf/website@f91f3f018dea1d367944262278d97ff60dfa8d53 : refactor space open/closed to use a persistent flag file
  • warewolf/website@d63bbd199f1df94b5afe1de8e3a59a7cb0619aa1 : expose the state & last modified time of the space open/closed flag file

I was able to test warewolf/website@d63bbd199f1df94b5afe1de8e3a59a7cb0619aa1 on my own personal website (since I happen to like HTML::Mason too), but I don't have a full copy of the nova-labs website up and running in a sandbox yet.

warewolf/website@f91f3f018dea1d367944262278d97ff60dfa8d53 is nearly trivial, so I don't think it should cause any problems.

Jason, could you take a look at these changes, pull 'em into the repo, and push to live if you approve?

Thanks.

@ghost ghost assigned jasonk May 19, 2012
@tmarkson
Copy link
Contributor

Hey, how was this message sent?- ted
On May 19, 2012 1:33 PM, "warewolf" <
[email protected]>
wrote:

@jasonk
Copy link
Member

jasonk commented May 19, 2012

He submitted a pull request through github, asking for changes to his fork to be pulled into the main repo, which sent the message..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 3:55 PM, Ted Markson [email protected] wrote:

Hey, how was this message sent?- ted
On May 19, 2012 1:33 PM, "warewolf" <
[email protected]>
wrote:

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804349

@tmarkson
Copy link
Contributor

Good to know.

Jason, is this the way you want merges to be requested? Would you add these
instructions and any others to a procedure for everyone to reference? At
least I would appreciate a defined method for this process! : )

Ted
On May 19, 2012 4:30 PM, "Jason Kohles" <
[email protected]>
wrote:

He submitted a pull request through github, asking for changes to his fork
to be pulled into the main repo, which sent the message..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 3:55 PM, Ted Markson [email protected] wrote:

Hey, how was this message sent?- ted
On May 19, 2012 1:33 PM, "warewolf" <
[email protected]>
wrote:

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804349

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804529

@jasonk
Copy link
Member

jasonk commented May 19, 2012

I'm working on it, things are crazy at the moment..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 5:52 PM, Ted Markson [email protected] wrote:

Good to know.

Jason, is this the way you want merges to be requested? Would you add these
instructions and any others to a procedure for everyone to reference? At
least I would appreciate a defined method for this process! : )

Ted
On May 19, 2012 4:30 PM, "Jason Kohles" <
[email protected]>
wrote:

He submitted a pull request through github, asking for changes to his fork
to be pulled into the main repo, which sent the message..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 3:55 PM, Ted Markson [email protected] wrote:

Hey, how was this message sent?- ted
On May 19, 2012 1:33 PM, "warewolf" <
[email protected]>
wrote:

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804349

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804529

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5805030

@tmarkson
Copy link
Contributor

Cool beans Jason!

Richard, can you think of a way tor show who is at the space? Such as
selecting people from a list of usernames on status.html. Or just adding a
textbox to let someone enter names manually.- ted
On May 19, 2012 6:46 PM, "Jason Kohles" <
[email protected]>
wrote:

I'm working on it, things are crazy at the moment..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 5:52 PM, Ted Markson [email protected] wrote:

Good to know.

Jason, is this the way you want merges to be requested? Would you add
these
instructions and any others to a procedure for everyone to reference? At
least I would appreciate a defined method for this process! : )

Ted
On May 19, 2012 4:30 PM, "Jason Kohles" <
[email protected]>
wrote:

He submitted a pull request through github, asking for changes to his
fork
to be pulled into the main repo, which sent the message..

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 3:55 PM, Ted Markson [email protected]
wrote:

Hey, how was this message sent?- ted
On May 19, 2012 1:33 PM, "warewolf" <
[email protected]>
wrote:

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804349

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5804529

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5805030

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5805374

@warewolf
Copy link
Contributor Author

Ted- that'd be a really cool idea, let me see how the SpaceMan stuff works and get back to you on it.

@jasonk
Copy link
Member

jasonk commented May 20, 2012

To just get a list of everyone in the database, you could do something like this:

    % for my $person ( $SpaceMan->people->all ) {
  • <% $person->name %>
    • % }

However, I think we should talk about something a bit more complicated.. We should do something about having people sign in so that we can also display in the space itself who is around and what things they might be able to help you with..

I also don't really like the idea of a list of who is there that is built by other people, sometimes I may not want people to know where I am. :)

Jason Kohles - www.jasonkohles.com
"A witty saying proves nothing." -- Voltaire

On May 19, 2012, at 11:55 PM, warewolf [email protected] wrote:

Ted- that'd be a really cool idea, let me see how the SpaceMan stuff works and get back to you on it.

Reply to this email directly or view it on GitHub:
https://github.com/nova-labs/website/pull/4#issuecomment-5806497

@warewolf
Copy link
Contributor Author

Lets move this discussion on a second enhancement to another issue, #5.

@warewolf
Copy link
Contributor Author

warewolf commented Jun 2, 2012

Bump? It's been two weeks w/ no movement on this, @jasonk can you make this live? This is holding up some of the social media stuff that Joey is trying to move forward.

Thanks.

jasonk added a commit that referenced this pull request Jun 3, 2012
@jasonk
Merge pull request #4 from warewolf/master
b042afb 
Enhancement: Expose space open/closed status for RSS feed
@jasonk jasonk merged commit b042afb into nova-labs:master Jun 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jasonk jasonk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warewolf @tmarkson @jasonk