Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security upgrades #94

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Security upgrades #94

merged 3 commits into from
Jul 12, 2019

Conversation

sdh100shaun
Copy link
Collaborator

security-upgrades addressing #93

 === npm audit security report ===

found 0 vulnerabilities

yarn audit v1.16.0
0 vulnerabilities found - Packages audited: 16970

We seem to have got ourselves in a place where we are using two dependency managers @jhigman (yarn and npm) shall we plump for one or the other

@jhigman
Copy link
Collaborator

jhigman commented Jul 12, 2019

Good idea! Which do you prefer? (I don't have any preference)

@sdh100shaun
Copy link
Collaborator Author

lazy me says readme says yarn :-) I will remove package-lock in this commit

@jhigman
Copy link
Collaborator

jhigman commented Jul 12, 2019

Thanks Shaun, nice one

@sdh100shaun sdh100shaun merged commit 97e66ac into master Jul 12, 2019
@sdh100shaun sdh100shaun deleted the security-upgrades branch July 12, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants