Merge pull request #54 from fix/regex-pattern

The regex pattern being used to validate if a module-path was a Github repository did not allow for underscores in the user/repository name Fixes the miss, also adds `.DS_Store` to .gitignore — for this project, and for generated projects! Signed-off-by: notsatan <[email protected]>
notsatan · Feb 5, 2024 · 168aa85 · 168aa85
2 parents e146f9e + 7657694
commit 168aa85
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -2,3 +2,5 @@
 .idea/
 .vscode/
 venv/
+
+.DS_Store/**
diff --git a/hooks/pre_gen_project.py b/hooks/pre_gen_project.py
@@ -11,7 +11,7 @@ def is_module_hosted_on_github():
     """
 
     # Regex pattern to validate module name - might need some tweaks
-    pattern = r"^github.com\/[a-zA-Z0-9\-]+\/[a-zA-Z0-9\-]+\/?$"
+    pattern = r"^github.com\/[\w\-]+\/[\w\-]+\/?$"
 
     # If the user has not opted for Github-specific features, skip
     perform_check: bool = bool(

diff --git a/{{ cookiecutter.project_name.strip() }}/.gitignore b/{{ cookiecutter.project_name.strip() }}/.gitignore
@@ -2,6 +2,9 @@
 .vscode/**
 .idea/**
 
+# Mac only
+.DS_Store/**
+
 # Ignore directories containing binaries generated and other stuff
 tmp/**
 bin/**
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,3 +2,5 @@ @@
     .idea/
     .vscode/
     venv/
+    .DS_Store/**