feat: blob sign command
#1128
Open
feat: blob sign command
#1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
==========================================
+ Coverage 70.79% 72.50% +1.70%
==========================================
Files 48 50 +2
Lines 2945 3139 +194
==========================================
+ Hits 2085 2276 +191
- Misses 668 670 +2
- Partials 192 193 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Dec 27, 2024
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
reviewed
Jan 7, 2025
| return err | ||
| } | ||
| signaturePath := signatureFilepath(cmdOpts.signatureDirectory, cmdOpts.blobPath, cmdOpts.SignatureFormat) | ||
| fmt.Printf("Writing signature to file %s\n", signaturePath) |
There was a problem hiding this comment.
Is it better to be a debug log?
| } | ||
| if !isRoot { | ||
| return notation.SignBlobOptions{}, fmt.Errorf("certificate from %q is not a root certificate. Expecting single x509 root certificate in PEM or DER format from the file", opts.tsaRootCertificatePath) | ||
|
|
There was a problem hiding this comment.
empty line.
Suggested change
Comment on lines
+220
to
+240
| rootCerts, err := corex509.ReadCertificateFile(opts.tsaRootCertificatePath) | ||
| if err != nil { | ||
| return notation.SignBlobOptions{}, err | ||
| } | ||
| if len(rootCerts) == 0 { | ||
| return notation.SignBlobOptions{}, fmt.Errorf("cannot find any certificate from %q. Expecting single x509 root certificate in PEM or DER format from the file", opts.tsaRootCertificatePath) | ||
| } | ||
| if len(rootCerts) > 1 { | ||
| return notation.SignBlobOptions{}, fmt.Errorf("found more than one certificates from %q. Expecting single x509 root certificate in PEM or DER format from the file", opts.tsaRootCertificatePath) | ||
| } | ||
| tsaRootCert := rootCerts[0] | ||
| isRoot, err := nx509.IsRootCertificate(tsaRootCert) | ||
| if err != nil { | ||
| return notation.SignBlobOptions{}, fmt.Errorf("failed to check root certificate with error: %w", err) | ||
| } | ||
| if !isRoot { | ||
| return notation.SignBlobOptions{}, fmt.Errorf("certificate from %q is not a root certificate. Expecting single x509 root certificate in PEM or DER format from the file", opts.tsaRootCertificatePath) | ||
|
|
||
| } | ||
| rootCAs := x509.NewCertPool() | ||
| rootCAs.AddCert(tsaRootCert) |
There was a problem hiding this comment.
We may need to function for preparing TSA root cert and can be shared in both OCI signing and blob signing command to reduce repeated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
notation blob signcommand with E2E tests.It's an implementation of spec: https://github.com/notaryproject/notation/blob/main/specs/commandline/blob.md#notation-blob-sign