-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved navigation #132
Open
steveww
wants to merge
23
commits into
notandy:master
Choose a base branch
from
steveww:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improved navigation #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will try your suggestion ASAP. With regards to Dirble, there's a new pull request that fixes it, allowing you to set custom API key. Maybe you could bring it back using this patch: Thanks, Michael |
OK I will test these and investigate a fix.
Regards,
Steve Waterworth
[email protected]
… On 18 Feb 2017, at 10:55, Miodrag Milić ***@***.***> wrote:
This looks awesome.
I noticed few important problem so far:
Each time I add stream I get segmentation fault. After its added, I can't start ympd any more, it fails on start until I remove stream from mpd queue.
Add all button doesn't work on search results which makes its purpose dummy (you already have + in browser form) - this was actually the main feature I was hopping for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#132 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFK3nrjDiCpsKIwFbvD59gNelMefeZTHks5rds4SgaJpZM4I3lE->.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to connect to Dirble did not provide any feedback, diagnostic information is now shown. Looks like the auth token has expired.
With a large collection scrolling through 512 entries at a time is a bit tiresome especially on a small mobile device. Add in quick navigation based on the alphabet.
I hope you like it.