v0.2 housekeeping: non_exhaustive all the things #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knickish
commented
Oct 8, 2024
| @@ -16,7 +16,6 @@ | |||
| //! For `#[nserde(..)]` supported attributes for each format check [Features support matrix](https://github.com/not-fl3/nanoserde#features-support-matrix) | |||
|
|
|||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
| #![cfg_attr(not(feature = "std"), feature(error_in_core))] | |||
There was a problem hiding this comment.
This will set our msrv for no_std to 1.81, but I think it's worth it so that nightly isn't a concern any more
There was a problem hiding this comment.
This will set our msrv for
no_stdto 1.81, but I think it's worth it so that nightly isn't a concern any more
I agree, 0.2 will be a good moment to push msrv!
knickish
commented
Oct 8, 2024
| @@ -61,12 +61,19 @@ pub trait DeBin: Sized { | |||
|
|
|||
| /// The error message when failing to deserialize from raw bytes. | |||
| #[derive(Clone)] | |||
| #[non_exhaustive] | |||
There was a problem hiding this comment.
I'm not ready to add new error messages right now, but this will at least let us make changes to this in future so that we can include a message field like in DeRonError or DeJsonError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a handful of build warnings that show up in CI, and put
non_exhaustiveon most public structs so that they can be adjusted without breaking changes in future