Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIP-34: clarify issue title #1505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanConwayDev
Copy link
Contributor

added as dluvian implemented the title as a subject tag in voyage which caused the issue title not to display in may clients such as: amethyst, Nostter, nostrudel, coracle and gitworkshop.

nostr:nevent1qvzqqqqx25pzpgqgmmc409hm4xsdd74sf68a2uyf9pwel4g9mfdg8l5244t6x4jdqy88wumn8ghj7mn0wvhxcmmv9uqzqqta74rkqgzt4akdw3acrparwnq46u2dusg4fzuu2d7ppyhgcmu6kz2ahd

added as dluvian implemented the title as a `subject` tag in voyage
which caused the issue title not to display in may clients such as:
amethyst, Nostter, nostrudel, coracle and gitworkshop.

nostr:nevent1qvzqqqqx25pzpgqgmmc409hm4xsdd74sf68a2uyf9pwel4g9mfdg8l5244t6x4jdqy88wumn8ghj7mn0wvhxcmmv9uqzqqta74rkqgzt4akdw3acrparwnq46u2dusg4fzuu2d7ppyhgcmu6kz2ahd
@vitorpamplona
Copy link
Collaborator

vitorpamplona commented Sep 19, 2024

I would prefer that clients change to show the subject as the title. The NIP just needs to add it to let people know this is the case.

@DanConwayDev
Copy link
Contributor Author

@dluvian also thinks that.
I don't mind changing but right now it displays really well on a lot of clients. My assumption is that a lot of clients show the content of events with an unknown event kinds.

My concern is every client will have opt-in to displaying the title and otherwise just show the body which will omit context.

@fiatjaf
Copy link
Member

fiatjaf commented Sep 19, 2024

A lot of clients show the subject tag too.

But if your main concern is just displaying on all clients then this should be a kind 1 if taken to the extreme.

@dluvian
Copy link
Contributor

dluvian commented Sep 19, 2024

The NIP just needs to add it to let people know this is the case.

I have a PR for this: #1446

@DanConwayDev
Copy link
Contributor Author

A lot of clients show the subject tag too.

Can you give an example of a client that shows it in the preview of this referenced nostr git issue?
nostr:nevent1qvzqqqqqqypzpgqgmmc409hm4xsdd74sf68a2uyf9pwel4g9mfdg8l5244t6x4jdqy88wumn8ghj7mn0wvhxcmmv9uqzpyfr4pztjtjrwrfg89k76xtmgpcqerz3xr8u2fw7jn9mzhvvvsgeyylvdp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants