fix: fix _precache memory leak from LazySuite #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LazySuite keeps all a reference to all tests (even those that have been run) under self._precache. When running a large number of tests this can cause nose to use up all available system memory. This makes running the whole test suite impossible. This change fixes that issue and keeps the behaviour of LazySuite.__nonzero__ intact. All tests pass under python 2.7 that passed prior to the change (there are some for the coverage plugin that didn't and still don't pass).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LazySuite keeps all a reference to all tests (even those that have been
run) under self._precache. When running a large number of tests this can
cause nose to use up all available system memory. This makes running the
whole test suite impossible.
This change fixes that issue and keeps the behaviour of
LazySuite.__nonzero__intact. All tests pass under python 2.7 that passed prior to the change
(there are some for the coverage plugin that didn't and still don't
pass).