New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings when run with python -3 #1008

Open

sigfrido wants to merge 2 commits into nose-devs:master from sigfrido:master

sigfrido commented Jul 29, 2016

Fixes the following python 3 compat warnings when we run nose tests with python -3:

/src/nose/nose/pyversion.py:49: DeprecationWarning: Overriding eq blocks inheritance of hash in 3.x
/src/nose/unit_tests/mock.py:95: DeprecationWarning: dict.has_key() not supported in 3.x; use the in operator

Here there's also a suggestion to set hash = None if we're sure instances will never be hashed: http://stackoverflow.com/questions/15471333/how-to-eliminate-a-python3-deprecation-warning-for-the-equality-operator.

sigfrido added 2 commits

July 29, 2016 11:42


          Fix code giving warnings when run with python -3

f14d394


          Handles also old-style classes with no __hash__ method

31da035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet