Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Prepare NURBS Curves Net" node #5148

Merged
merged 14 commits into from
Oct 7, 2024
Merged

"Prepare NURBS Curves Net" node #5148

merged 14 commits into from
Oct 7, 2024

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Oct 6, 2024

Addressed problem description

If you want to build a Gordon surface (by use of "Surface from NURBS Curves Net" node), it is required that your curves intersect exactly. If your curves are not generated, but manually created (and introduced into Sverchok tree by use of "Bezier In" or "NURBS Input" nodes), it is hard to adjust curves manually so that they would exactly intersect.

Solution description

With this new node, you may say that, for example, U curves are "primary", and the surface should follow them exactly, and V curves are "secondary", they provide only approximate shape. Then the node will slightly adjust your V curves so that they would exactly intersect your U curves. Or vice versa, you can say that V curves are primary.

Initial curves net (note that curves do not intersect exactly):
Screenshot_20241006_163637

Here we say that U curves are primary. Black curves are original, red and blue curves are result of adjustment by the node. Note that now the curves intersect exactly.
Screenshot_20241006_162602
Screenshot_20241006_162624

And here we say that V curves are primary:
Screenshot_20241006_163453
Screenshot_20241006_163512

Simple example with "Crop" disabled:
Screenshot_20241006_202326

And the same with "Crop" enabled:
Screenshot_20241006_202311

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov added the NURBS label Oct 6, 2024
@portnov portnov merged commit ff02e7d into master Oct 7, 2024
1 of 2 checks passed
@portnov portnov deleted the prepare_curves_net branch October 7, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant