Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin assembly loading fix #222

Open
wants to merge 6 commits into
base: 13.1
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move deps count check
Axwabo committed Sep 1, 2023

Verified

This commit was signed with the committer’s verified signature.
simonpasquier Simon Pasquier
commit 1a7a1f60702bcdacfdc4975b29a0aac1e4a19263
11 changes: 6 additions & 5 deletions NwPluginAPI/Loader/AssemblyLoader.cs
Original file line number Diff line number Diff line change
@@ -141,6 +141,12 @@ private static void LoadPlugins(PluginDirectory directory)
{
if (missingDependencies.Count != 0)
ResolveAssemblyEmbeddedResources(pluginInfo.Assembly, missingDependencies);
if (missingDependencies.Count != 0)
{
Log.Error($"Failed loading plugin &2{Path.GetFileNameWithoutExtension(pluginInfo.Path)}&r, missing dependencies\n&2{string.Join("\n", missingDependencies.Select(x => "&r - &2" + x + "&r"))}", "Loader");
continue;
}

pluginInfo.Types = pluginInfo.Assembly.GetTypes();
pluginsToInitialize.Add(pluginInfo);
}
@@ -155,11 +161,6 @@ private static void LoadPlugins(PluginDirectory directory)
Log.Error("Failed loading plugin &2" + Path.GetFileNameWithoutExtension(pluginInfo.Path) + "&r, " + e, "Loader");
}
}

if (missingDependencies.Count != 0)
{
Log.Error($"Failed loading plugin &2{Path.GetFileNameWithoutExtension(pluginInfo.Path)}&r, missing dependencies\n&2{string.Join("\n", missingDependencies.Select(x => "&r - &2" + x + "&r"))}", "Loader");
}
}

Log.Info($"Initializing &2{pluginsToInitialize.Count}&r plugins...");