-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support brushless servo upgrade #162
Conversation
This compiles and runs on real hardware (non-brushless), running the old/current code. |
Yeah, the Right Way to do this is to add device configuration support to saxi, which it sort-of-kind-of has the beginnings of (you found it with the ToolingProfile and Device interfaces), but this has never been exposed in the UI (either web or CLI), and hasn't really been well developed in the code either. My suggestion for the fastest way to get something like this landed would be to add support for alternative device configurations to the CLI only, i.e. the plot command mode and the server mode, as a command-line flag. e.g. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alex Ruddick <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit 4d4fe36.
I wonder if we can detect the model through ebb api... |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Dahan <[email protected]>
Migrate from webpack to esbuild. This speeds up start times, allows for live reloads, and makes saxi buildable on a raspberry pi zero (webpack OOMs even with 1.5Gb of memory). --------- Co-authored-by: Jonathan Dahan <[email protected]> Co-authored-by: Alex Ruddick <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
f061831
to
a2ee760
Compare
I'd love to merge something like this, but it's still in a pretty messy state, including several refactors. Perhaps we could break out the unrelated refactors into separate PRs, then build the brushless support on top? |
Yep, we've already got brushless support working in the fork at alexrudd2#114 but this was an earlier branch. Since things were starting to diverge, I created a project to track changes to submit upstream (i.e. to you). https://github.com/users/alexrudd2/projects/1. I'll have to go back and rebase now that several PRs have been merged in. |
Closing in favor of #197 |
Closes #136
This intends to add support for the brushless servo upgrade kit.
See:
theophoric@467c814
evil-mad/axidraw@v3.7.2...v3.8.0
#136 (comment)
I think this should be a configurable option rather than a permanent change. The same software should be able to support both motor options. Therefore, I've attempted a lower-level refactor. I don't know the best way to expose a configuration option.
@nornagon can you help me out here?