Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change seed to random key for linalg #13

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Change seed to random key for linalg #13

merged 2 commits into from
Apr 19, 2024

Conversation

SamDuffield
Copy link
Contributor

Passing the random_key rather than seed is better for JAX composability

@SamDuffield SamDuffield requested a review from KaelanDt April 19, 2024 14:00
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamDuffield SamDuffield merged commit 23d395c into main Apr 19, 2024
2 checks passed
@SamDuffield SamDuffield deleted the seed branch April 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants