Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure inplace defaults to False #97

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Ensure inplace defaults to False #97

merged 1 commit into from
Jun 5, 2024

Conversation

SamDuffield
Copy link
Contributor

Just unifying the defaults for torchopt and laplace.dense_fisher

farice
farice approved these changes Jun 5, 2024
View reviewed changes
Copy link

@farice farice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests to demonstrate effects?

@farice
Copy link

farice commented Jun 5, 2024

Nvm it's just defaults

@SamDuffield
Copy link
Contributor Author

Any tests to demonstrate effects?

There are already tests for both inplace=True and inplace=False, this simply unifies the default behaviour.

We don't currently explicitly test default behaviour, although this could be interesting to scope out for a future PR 😎

@SamDuffield SamDuffield merged commit 03de980 into main Jun 5, 2024
2 checks passed
@SamDuffield SamDuffield deleted the inplace-False branch June 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farice farice farice approved these changes

@KaelanDt KaelanDt Awaiting requested review from KaelanDt

@johnathanchiu johnathanchiu Awaiting requested review from johnathanchiu

@phoebeklett phoebeklett Awaiting requested review from phoebeklett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @farice