Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Fixed an unknown symbol error when importing libpointmatcher's Python bindings on arm64-based MacOS.
Also, fixed failing tests on new boost version.
Changes and type of changes (quick overview):
pypointmatcher
in Python on arm64-based MacOS, I was getting this error:"ImportError: dlopen(/Volumes/CaseSensitive/libpointmatcher/python/pypointmatcher/pypointmatcher_native.cpython-312-darwin.so, 0x0002): symbol not found in flat namespace '__ZNK14PointMatcherIOIfE10PLYElementeqERKS1_'"
Demangling the symbol error, it complains about this function:
__eq__
method withpybind11::self == pybind11::self
andpybind11::self != pybind11::self
and overwriting the C++operator==
andoperator!=
with friend functions.Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
(See commit_msg_reference.md for details)