-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/twitter oauth #23
Conversation
….txt adds the ability to split out testing dependencies from the application runtime dependencies
the twitter api is becoming prohibitive to use so removing friends reduces dependency BREAKING CHANGE:
If you have a chance to look at why CI is failing, that would be much appreciated! Something dependency-based. By the way, another thought I had was... the site is hosted on Heroku, it uses their buildpacks, not the Docker config. Do you know if the switch to pyproject.toml will work other there? |
Fixed this, the reference to the
I think this will work with the empty |
Brilliant! Lets give this a try... |
Awesome. Thank you so much @phillipjf for this! Once I had all the API creds in the right place, it worked flawlessly. |
This MR switches Twitter login over to use Twitter OAuth2.0 for fetching the username. This is primarily for historical purposes to continue using Twitter usernames for identifying users. Due to changes with the Twitter API, the friends functionality is no longer feasible to maintain and was not exposed in the UI anyways. Flask-Dance project even removed Twitter in a recent release Flask-Dance#416
BREAKING: This MR includes a migration to remove the friends association in the DB.
Resolves #21.