fix: exclude backslashes from initially generated passwords #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raits
requested changes
Feb 7, 2025
Comment on lines
139
to
141
| for _ in range(1000): | ||
| password = create_users._generate_password() | ||
| assert backslash_char not in password |
There was a problem hiding this comment.
I understand why this is tested like that, but perhaps there is a better way to test the behavior of the logic rather than the end result. To me this seems like it would make for a hard to understand sometimes failing / sometimes not test.
There was a problem hiding this comment.
good point. What about now?
Comment on lines
163
to
167
| def test_generated_password_has_no_backslashes(): | ||
| backslash_char = "\\" | ||
| for _ in range(1000): | ||
| password = create_users._generate_password() | ||
| assert backslash_char not in password |
There was a problem hiding this comment.
Same comment as for the MongoDB one.
nortaljevgenikr
force-pushed
the
OPMONDEV-192_exclude_backslash
branch
from
6b842e9 to
1ab8c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: OPMONDEV-192