Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies, apply fixes (code, and tox), and update docs #113

Merged
merged 14 commits into from
Jun 11, 2024

Conversation

melbeltagy
Copy link
Contributor

@melbeltagy melbeltagy commented Jun 10, 2024

  • Remove obsolete bitbucket pipeline
  • Upgrade dependencies
  • Update run_tests.sh to generate HTML report, add dependency, and ignore report from git
  • Add make clean command
  • Update tox configurations to fail on failing tests (to affect pipeline/github actions)
  • Remove opendata_collector_module from github actions (only keep production modules)
  • Code related fixes
  • Update docs for collector, corrector, and reports modules for consistency and readability
  • Add dependabot configurations
  • Add github jobs' names
  • Add caching for setup.py projects in github actions

Refs: OPMONDEV-182

Copy link
Contributor

@raits raits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall looks good to me.

applies-to: version-updates
update-types:
- "major"
reviewers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not do the automatic reviewer part here, since most of the core team is probably not familiar enough with Python to review this. We can just leave it without a reviewer for now and keep an eye on them.

applies-to: version-updates
patterns:
- "*"
reviewers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above (even if this is not Python).

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@melbeltagy melbeltagy merged commit 2c40419 into develop Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants