Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jsonc for pretty comments and lint #192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HarHarLinks
Copy link
Contributor

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Not sure if I like what the linter did. I guess it's inconsistent now?

@HarHarLinks HarHarLinks requested review from a team and weeman1337 November 29, 2024 18:02
Signed-off-by: Kim Brose <[email protected]>
@weeman1337
Copy link
Contributor

We should maybe not do this in the documentation. What happens if you copy the code to the actual configuration? Are comments and the trailing commas working? Does it support .jsonc files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants