[no-jira] Add "Newer" and "Older" navigation to Posts page #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cznrhubarb
changed the title
Predjo
approved these changes
Feb 22, 2024
| @@ -44,6 +44,7 @@ | |||
| "post.myTimeline": "Mi Línea del tiempo", | |||
| "post.wasLive": "estuvo en vivo", | |||
| "post.copyPath": "Copiar camino", | |||
| "post.openInNewTab": "Open in new tab", | |||
There was a problem hiding this comment.
Coach ops told me I can leave anything that's only coach facing in English, so I made this coach facing only even if it would be useful for users, just so I wouldn't have to translate it :D
| return ( | ||
| <Wrapper> | ||
| <CommunityInfo communityId={communityId} /> | ||
|
|
||
| { | ||
| isCoach(currentUser) && |
There was a problem hiding this comment.
Nit: Add some margin to the bottom and adjust ButtonGroup spacing so it matches the spacing with the top card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Coaches suffer from an issue where there pages refresh due to excessive scrolling. We've been unable to pinpoint and fix the problem, so I want to introduce a work around that avoids the scrolling.
Changes
Added an "open in new tab" option to post context menus.
Added "Newer" and "older" navigation buttons to the posts page.
Testing Done
Screenshots