Skip to content

Commit

Permalink
Merge pull request #7960 from liranmauda/liran-backport-into-514
Browse files Browse the repository at this point in the history
[Backport to 5.14] upgrade to node 20.11.0. ignore deprecated warnings to make nan compile. (#7660)
  • Loading branch information
liranmauda authored Apr 17, 2024
2 parents 70d1e4b + 74c5bb8 commit f1d472e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.2
20.11.0
2 changes: 2 additions & 0 deletions src/native/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
'-Wextra',
'-Werror',
'-Wpedantic',
#Can be removed when https://github.com/nodejs/nan/issues/953 is resolved.
'-Wno-error=deprecated-declarations'
],
# see https://nodejs.org/docs/latest-v12.x/api/process.html#process_process_arch
# Possible values are:
Expand Down

0 comments on commit f1d472e

Please sign in to comment.