Skip to content

Commit

Permalink
Fix spellcheck
Browse files Browse the repository at this point in the history
  • Loading branch information
johnwparent committed Oct 22, 2024
1 parent 37b264c commit f89582a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gpt4all-updater/README
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ There are two modes, offline and online, each is tested differently:

The online updater workflow takes a url endpoint (for early testing, this will be a file url) that points to a manifest file, a sample of which has been provided under the `tmp` directory relative to this README. The manifest file includes, amount other things specified in the updater RFC, another file URL to a gpt4all installer.

The first thing testing this will require is a manual update of that file url in the mainfest xml file to point to the DMG on MacOS or exe on Windows, of an existing online Gpt4All installer, as well as a corresponding sha256 sum of the given installer. The manifest is filled with other stub info for testing, you're welcome to leave it as is or fill it out correctly for each testing iteration.
The first thing testing this will require is a manual update of that file url in the manifest xml file to point to the DMG on MacOS or exe on Windows, of an existing online Gpt4All installer, as well as a corresponding sha256 sum of the given installer. The manifest is filled with other stub info for testing, you're welcome to leave it as is or fill it out correctly for each testing iteration.

That is all that is required for configuration. Now simply build this project via CMake, using standard CMake build practices. CMake will build the online installer by default, so no extra arguments are required.

One argument is required for the online installer, the url where the updater should expect the mainfest file to be. This can be any url accessible to your system, but for simplicity and testing reasons, its usually best to use a file url.
One argument is required for the online installer, the url where the updater should expect the manifest file to be. This can be any url accessible to your system, but for simplicity and testing reasons, its usually best to use a file url.
This is provided via the cmake command line argument `-DGPT4ALL_MANIFEST_ENDPOINT=<url>`.

Now configure and build the updater with CMake.
Expand Down
4 changes: 2 additions & 2 deletions gpt4all-updater/src/Download.cxx.in
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void Download::installInstaller(QString &expected, QFile *temp, QNetworkReply *i
this->downloadPath = new QFile(saveFilePath);
#endif
temp->deleteLater();
// Extraction is not requried on Windows because we download an exe directly
// Extraction is not required on Windows because we download an exe directly
gpt4all::state::Gpt4AllState::getInstance().setInstaller(this->downloadPath);
}

Expand All @@ -84,7 +84,7 @@ QNetworkReply * Download::downloadInMemory(QUrl &url)
return nullptr;
}
if (reply->error() != QNetworkReply::NoError) {
qWarning() << "Error: network error occured while downloading the release manifest:" << reply->errorString();
qWarning() << "Error: network error occurred while downloading the release manifest:" << reply->errorString();
reply->deleteLater();
}
return reply;
Expand Down

0 comments on commit f89582a

Please sign in to comment.