introduce SortedDataSelection class #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bmschmidt and the rest of your teammates on |
This was referenced Sep 16, 2024
Merged
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
eelegiap
approved these changes
Sep 18, 2024
bmschmidt
force-pushed
the
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
branch
from
b59865f
to
6fda8c1
Compare
bmschmidt
force-pushed
the
08-08-introduce_sorteddataselection_class
branch
from
3f1fa61
to
00ccb8b
Compare
Merge activity
|
bmschmidt
force-pushed
the
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
branch
from
6fda8c1
to
3c779e2
Compare
bmschmidt
force-pushed
the
08-08-introduce_sorteddataselection_class
branch
from
00ccb8b
to
39c3fa1
Compare
| let t; | ||
| indices: T, | ||
| ): Vector<Dictionary<Utf8, ArrayToArrayMap[T]>> { | ||
| let t: ArrayToArrayMap[T]; | ||
|
|
||
| if (indices[Symbol.toStringTag] === `Int8Array`) { |
There was a problem hiding this comment.
Use instanceof for type checking instead of Symbol.toStringTag.
Suggested change
| if (indices[Symbol.toStringTag] === `Int8Array`) { | |
| if (indices instanceof Int8Array) { |
bmschmidt
changed the base branch from
08-07-make_the_tiles_on_a_selection_a_struct_of_info_not_twinned_lists
to
graphite-base/144
bmschmidt
force-pushed
the
08-08-introduce_sorteddataselection_class
branch
from
39c3fa1
to
cb0bce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce SortedDataSelection class using a new pivot strategy
SortedDataSelection uses a lot more memory than a selection but enables getting the k-highest element quickly (roughly O(log N) time).
I went back a bunch with the fancy new GPT-4 chain of thought to make this.
Includes tests.
The next PR in this stack will allow faster in-order iteration over a list using a minheap structure.
feat: add
SortedDataSelectionclass for efficient data sorting and selectionSummary:
Introduce
SortedDataSelectionclass for efficient data sorting and selection with tests and future enhancements.Key points:
SortedDataSelectionclass for efficient k-highest element retrieval using a pivot strategy.DataSelectionto support new sorting functionality.SelectionTileclass to manage tile-specific sorting data.deepscatter.tsto includeSortedDataSelection.SortedDataSelectionindataset.spec.js.publish_docs_if_stable.shscript for documentation publishing.utilityFunctions.ts.Generated with ❤️ by ellipsis.dev