allow subfield access #141
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bmschmidt and the rest of your teammates on |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
bmschmidt
force-pushed
the
09-09-use_a_shared_object_with_multiple_length_keys_to_store_regl_buffers
branch
from
aa964e6
to
2dac6bb
Compare
bmschmidt
force-pushed
the
09-07-allow_subfield_access
branch
from
1cd7eec
to
9b53f80
Compare
src/aesthetics/Aesthetic.ts
Outdated
| for (let i = 0; i < this.subfield.length; i++) { | ||
| v = v[this.subfield[i]] as Input['domainType']; | ||
| } | ||
| return v; | ||
| // Needs a default perhaps? | ||
| return null; |
There was a problem hiding this comment.
The return null; statement is unreachable due to the preceding return v; statement. Consider restructuring the function to ensure all code paths are reachable.
bmschmidt
force-pushed
the
09-09-use_a_shared_object_with_multiple_length_keys_to_store_regl_buffers
branch
from
2dac6bb
to
c7a8537
Compare
bmschmidt
force-pushed
the
09-07-allow_subfield_access
branch
from
9b53f80
to
bff128f
Compare
src/aesthetics/Aesthetic.ts
Outdated
| for (let i = 0; i < this.subfield.length; i++) { | ||
| v = v[this.subfield[i]] as Input['domainType']; | ||
| } | ||
| return v; | ||
| // Needs a default perhaps? | ||
| return null; |
There was a problem hiding this comment.
The return null; statement is unreachable due to the preceding return statement. Consider handling the case where this.field is not found in point before the loop.
bmschmidt
force-pushed
the
09-09-use_a_shared_object_with_multiple_length_keys_to_store_regl_buffers
branch
3 times, most recently
from
d175c73
to
fb591fb
Compare
bmschmidt
force-pushed
the
09-07-allow_subfield_access
branch
from
bff128f
to
c96085d
Compare
src/aesthetics/Aesthetic.ts
Outdated
| for (let i = 0; i < this.subfield.length; i++) { | ||
| v = v[this.subfield[i]] as Input['domainType']; | ||
| } | ||
| return v; | ||
| // Needs a default perhaps? | ||
| return null; |
There was a problem hiding this comment.
The return statement here is unreachable due to the preceding return statement inside the if block. Consider removing it.
| @@ -824,8 +824,8 @@ export class DataSelection { | |||
| if (i === undefined) { | |||
| i = this.cursor; | |||
| } | |||
| if (i > this.selectionSize) { | |||
| undefined; | |||
| if (i >= this.selectionSize) { | |||
There was a problem hiding this comment.
The condition i > this.selectionSize should be i >= this.selectionSize to correctly handle out-of-bounds access.
|
same here, "trunk branch locked" |
bmschmidt
force-pushed
the
09-09-use_a_shared_object_with_multiple_length_keys_to_store_regl_buffers
branch
from
fb591fb
to
9cdf75f
Compare
bmschmidt
force-pushed
the
09-07-allow_subfield_access
branch
from
c96085d
to
09bb35d
Compare
| for (let i = 0; i < this.subfield.length; i++) { | ||
| v = v[this.subfield[i]] as Input['domainType']; | ||
| } | ||
| return v; |
There was a problem hiding this comment.
Unreachable code after return v; in value_for method. Remove the redundant return null; statement.
bmschmidt
force-pushed
the
09-09-use_a_shared_object_with_multiple_length_keys_to_store_regl_buffers
branch
from
9cdf75f
to
5903dbd
Compare
bmschmidt
force-pushed
the
09-07-allow_subfield_access
branch
from
09bb35d
to
a3d1a8a
Compare
| for (let i = 0; i < this.subfield.length; i++) { | ||
| v = v[this.subfield[i]] as Input['domainType']; | ||
| } | ||
| return v; |
There was a problem hiding this comment.
Redundant return statement. Remove the line after return v;.
This makes it possible for deepscatter to access not just single-depth fields, but also structs that can get probed into.
Struct<x: Float32, y: Float32>This is useful because often a single transformation should create two or more columns.
Important
Enhance Deepscatter by adding support for accessing subfields within struct fields, improving data transformation and rendering.
Aestheticclass to handle subfields.AestheticSetto support subfield access.regl_rendering.ts.selection.tsandscatterplot.tsto work with subfields.TupleMapandTupleSetinutilityFunctions.tsfor managing nested keys.Tileclass to support subfield access.This description was created by
for a3d1a8a. It will automatically update as commits are pushed.