Unit Tests - NomadBase, Replica, CI #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested changes
May 31, 2022
prestwich
previously requested changes
Jun 1, 2022
odyslam
force-pushed
the
feat/foundry-tests
branch
from
33812bc
to
c771b0c
Compare
anna-carroll
reviewed
Jun 2, 2022
packages/contracts-core/README.md
Outdated
|
|
||
| For testing, we use [Foundry](https://getfoundry.sh/). | ||
|
|
||
| - Run `yarn build:accumulator-cli` from the root directory of the monorepo. It will build a rust-based cli tool that creates Sparse Merkle Tree proofs for arbitrary data. It's used in our testing suite via the `--ffi` flag for Forge. The binary is built in thre `/scripts` top-level directory of the monorepo |
| vm.label(fakeSigner, "fake signer"); | ||
| } | ||
|
|
||
| function getMessage(bytes32 oldRoot, bytes32 newRoot, uint32 domain) |
There was a problem hiding this comment.
agreed this is an update not a message & we should rename
|
checks aren't running because this is a branch from a fork, so I can't tell if the changes to the workflow are themselves good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit-Tests:
Fuzzing:
Other:
Tracking: #283