fix: mostly pretty links, fix dev warnings #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for zealous-poitras-b7e416 failed. 🔨 Explore the source changes: ea6a2ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/zealous-poitras-b7e416/deploys/62043cb9ea16dc0008bed40e |
|
Gonna close, really don't like this solution of editing the vitepress dependency. We should live with this or switch to a different ssg if we feel strongly enough about fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of #23
Most links should not have the
.htmlending now. The ones that still exist are routes that are linked inmdfiles.There is no way to get around this in vitepress. The only workaround I found was editing the vitepress dependency directly post install (see package.json and this issue from vitepress)
Perfectly fine if we choose not to merge this change since I don't think the
.htmlendings is a big deal (vitepress main site has the same "problem" - https://vitepress.vuejs.org/config/basics.html)