Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain about the fork #769

Merged
merged 1 commit into from
Jan 13, 2020
Merged

explain about the fork #769

merged 1 commit into from
Jan 13, 2020

Conversation

ziirish
Copy link
Collaborator

@ziirish ziirish commented Jan 10, 2020

Let the community know about the fork and give some context.

cc. @j5awry, @SteadBytes

@coveralls
Copy link

coveralls commented Jan 10, 2020

Coverage Status

Coverage increased (+0.09%) to 96.923% when pulling 9389964 on fork into 9232e1a on master.

@SteadBytes
Copy link
Collaborator

Thanks for putting this together @ziirish this is great. I'm just wondering if it might be beneficial to re-arrange slightly and start with the fork notice. This makes it immediately obvious that this project should be considered unmaintained and that the new fork is where ongoing development will take place. The explanation of why could then follow :) Something like this perhaps?

IMPORTANT NOTICE:

This project has been forked to flask-restx and will be maintained by by the python-restx organization. Flask-RESTPlus should be considered unmaintained.

The community has decided to fork the project due to lack of response from the original author @noirbizarre. We have been discussing this eventuality for almost a year.

Things evolved a bit since that discussion and a few of us have been granted maintainers access to the github project, but only the original author has access rights on the PyPi project. As such, we been unable to make any actual releases. To prevent this project from dying out, we have forked it to continue development and to support our users.

@ziirish
Copy link
Collaborator Author

ziirish commented Jan 11, 2020

Thanks for the review.

I'll update the README accordingly to your version which I prefer over mine :)

@SteadBytes
Copy link
Collaborator

Awesome thank you for taking the feedback on board! 😊

Would you mind fixing up those extra couple of commits into the first one? Just to keep the history cleaner, then we should merge! 🎉

@ziirish
Copy link
Collaborator Author

ziirish commented Jan 12, 2020

done

@SteadBytes SteadBytes merged commit e9d5632 into master Jan 13, 2020
@rogeriolino
Copy link

Congrats guys. These project must (still) be maintaned.

But, what about the new name?

@ziirish
Copy link
Collaborator Author

ziirish commented Jan 14, 2020

@rogeriolino I'm not sure to understand your question.

We have added the links to the fork in the README and I opened and pinned an issue with all the informations: #770

What would you like to know?

@rogeriolino
Copy link

@ziirish is about the org/project suffix restx.

I was following the #743 issue, where forks naming was suggested, and I dont read about the these new name.

Just for curiosity.

Regards

@ziirish
Copy link
Collaborator Author

ziirish commented Jan 14, 2020

So you want to know why we chose restx?

I'm thinking of adding the reason in flask-restx' README at some point.
The idea comes from a discussion on the gitter channel. It's a proposal of @apryor6.

flask-restx as an 'x' is just like a '+', with a twist :)

Most of us liked the idea, hence the new name.

The discussion is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants