Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/HC improvements for zk-regex Noir support #8

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Sep 19, 2024

  1. feat: initial noir support (#1)

    olehmisar authored and ewynx committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8ded16e View commit details
    Browse the repository at this point in the history
  2. Added gen_substrs support for Noir. This works both in decomposed & r…

    …aw setting.
    
    The substrings are returned as BoundedVec since we don't know their exact length upfront, but we know they're not longer than N.
    To support both settings (decomposed and raw) we have to use `substring_ranges` instead of `substring_boundaries`.
    ewynx committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    db2e129 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    33736ca View commit details
    Browse the repository at this point in the history
  4. Per state 1 or more substrings will be extracted, depending on the re…

    …gex and input. This fix makes sure this is supported.
    
    Changes:
    - regex_match returns a Vec of substrings instead of an array with known length
    - per state where substrings have to be extracted; add the byte either to a new substring or an already started one
    
    Note that substr_count is used to extract the correct "current" substring from the Vec. This is a workaround - first implementation was using `pop` but this gave an error.
    ewynx committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f7ae186 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    3a853e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. $ and ^ support

    For caret anchor: Mark beginning of input byte array with 255, which makes the check for caret anchor (ˆ) works. Note that ^ is only taken into consideration in the decomposed mode.
    ewynx committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8e6aa14 View commit details
    Browse the repository at this point in the history
  2. Added the "reset" flow when a shortcut is made from any state to the …

    …states reachable from state 0.
    
    Substrings only get saved when they are part of a path that doesn't reset.
    ewynx committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9f3acd6 View commit details
    Browse the repository at this point in the history
  3. Removed old code

    ewynx committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4137890 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd14d89 View commit details
    Browse the repository at this point in the history