forked from zkemail/zk-regex
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/HC improvements for zk-regex Noir support #8
Open
ewynx
wants to merge
9
commits into
noir-lang:main
Choose a base branch
from
hashcloak:features/hc_improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8ded16e - Browse repository at this point
Copy the full SHA 8ded16eView commit details -
Added gen_substrs support for Noir. This works both in decomposed & r…
…aw setting. The substrings are returned as BoundedVec since we don't know their exact length upfront, but we know they're not longer than N. To support both settings (decomposed and raw) we have to use `substring_ranges` instead of `substring_boundaries`.
Configuration menu - View commit details
-
Copy full SHA for db2e129 - Browse repository at this point
Copy the full SHA db2e129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33736ca - Browse repository at this point
Copy the full SHA 33736caView commit details -
Per state 1 or more substrings will be extracted, depending on the re…
…gex and input. This fix makes sure this is supported. Changes: - regex_match returns a Vec of substrings instead of an array with known length - per state where substrings have to be extracted; add the byte either to a new substring or an already started one Note that substr_count is used to extract the correct "current" substring from the Vec. This is a workaround - first implementation was using `pop` but this gave an error.
Configuration menu - View commit details
-
Copy full SHA for f7ae186 - Browse repository at this point
Copy the full SHA f7ae186View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3a853e7 - Browse repository at this point
Copy the full SHA 3a853e7View commit details
Commits on Oct 1, 2024
-
For caret anchor: Mark beginning of input byte array with 255, which makes the check for caret anchor (ˆ) works. Note that ^ is only taken into consideration in the decomposed mode.
Configuration menu - View commit details
-
Copy full SHA for 8e6aa14 - Browse repository at this point
Copy the full SHA 8e6aa14View commit details -
Added the "reset" flow when a shortcut is made from any state to the …
…states reachable from state 0. Substrings only get saved when they are part of a path that doesn't reset.
Configuration menu - View commit details
-
Copy full SHA for 9f3acd6 - Browse repository at this point
Copy the full SHA 9f3acd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4137890 - Browse repository at this point
Copy the full SHA 4137890View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd14d89 - Browse repository at this point
Copy the full SHA cd14d89View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.