Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: proposed change here is an addition of a single line, the rest is the original Noir support @olehmisar built.
^
causes the DFA to contain an extra state beforehand that has a transition for 255, which marks the start of the input byte array. In the regex_match function the input is then prefixed with 255 to execute the check. This implementation follows the one of circom. As checked in the TG group, this assumes 255 won't appear in the rest of the input byte string as valid ASCII.If the regex doesn't start with a "ˆ" this doesn't do anything because then the mapping is to 0.
Note that ^ is only taken into consideration in the decomposed mode.
Example test input for
ˆ[0-9]{2}/[0-9]{2}/[0-9]{4}
:With
cargo run --bin zk-regex decomposed -d <filepath>.json --noir-file-path caret_anchor_test.nr
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmt
on default settings.