Fixing: responsiveness, filter. Adding: font parameter #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redek91 thanks a lot for the quick fixes, I see above that some checks were not succesful - can you check? I then ask @clezag to check, integrate and deploy so that we can see the updates on https://webcomponents.opendatahub.testingmachine.eu/webcomponent/sustainability-apps |
|
@rcavaliere I just understood how the manifest works. I pushed a fix, the tests are all clear now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I fixed the problems with the responsiveness and filter not hiding. I also introduced a new font-family parameter to set the font family. I have to check this parameter when it is pushed to the test component store.