Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate error handling for graph build step #202

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

leonardehrenfried
Copy link
Contributor

@leonardehrenfried leonardehrenfried commented Aug 20, 2024

The script actually has error handling but it's skipped when it's run with bash build-graph.sh.

This makes the build fail when the NeTex file cannot be downloaded, which is what we want (rather than silently continuing).

@dulvui

@leonardehrenfried
Copy link
Contributor Author

As expected the graph build fails because the NeTEx file cannot be downloaded:

Downloading NeTEx transit data from ftp://ftp01.sta.bz.it/netex/2024/plan/EU_Profil/NX-PI_01_it_apb_LINE_apb__20240820.xml.zip
#=#=#                                                                         
##O#-#                                                                        
##O=#  #                                                                      
#=#=-#  #                                                                     
-#O#- #   #                                                                   
-=#=#   #   #                                                                 
curl: (9) Server denied you to change to the given directory

I think we should merge this anyway so we know when there is a problem downloading the NeTEx file.

@dulvui dulvui merged commit 671ef44 into noi-techpark:main Aug 20, 2024
1 check failed
@leonardehrenfried leonardehrenfried deleted the patch-1 branch August 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants