WIP refactor title of news/event details screen

noi-techpark · Dec 6, 2024 · bf312fa · bf312fa
1 parent 24be6e8
commit bf312fa
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/NOICommunity/Coordinator/Implementations/Custom/AppCoordinator.swift b/NOICommunity/Coordinator/Implementations/Custom/AppCoordinator.swift
@@ -205,6 +205,7 @@ private extension AppCoordinator {
 		guard let topViewController
 		else { return }
 
+		// TODO: remove after title refactor
         func configureBindings(
             viewModel: NewsDetailsViewModel,
 			pageViewController: NewsPageViewController
@@ -254,6 +255,7 @@ private extension AppCoordinator {
 			return pageVC
 		}()
 
+		// TODO: remove after title refactor
         configureBindings(
             viewModel: viewModel,
 			pageViewController: pageVC
@@ -314,6 +316,7 @@ private extension AppCoordinator {
 		guard let topViewController
 		else { return }
 
+		// TODO: move set navigationItem title here
 		func configureBindings(
 			viewModel: EventDetailsViewModel,
 			pageViewController: EventPageViewController
@@ -355,7 +358,9 @@ private extension AppCoordinator {
 				self?.signupEvent($0, from: pageVC)
 			}
 
+			// TODO: move set navigationItem title here
 			pageVC.navigationItem.title = nil
+
 			pageVC.navigationItem.largeTitleDisplayMode = .never
 			pageVC.navigationItem.leftBarButtonItem = UIBarButtonItem(
 				image: UIImage(systemName: "xmark.circle.fill"),

diff --git a/NOICommunity/EventsFeature/Coordinators/EventsCoordinator.swift b/NOICommunity/EventsFeature/Coordinators/EventsCoordinator.swift
@@ -121,7 +121,9 @@ private extension EventsCoordinator {
 				self?.signupEvent($0)
 			}
 
+			// TODO: remove after title refactor
 			pageVC.navigationItem.title = event.title
+
 			pageVC.navigationItem.largeTitleDisplayMode = .never
 
 			return pageVC

diff --git a/NOICommunity/EventsFeature/View Controllers/EventPageViewController.swift b/NOICommunity/EventsFeature/View Controllers/EventPageViewController.swift
@@ -68,6 +68,8 @@ final class EventPageViewController: BasePageViewController<EventDetailsViewMode
 				guard let self
 				else { return }
 
+				// TODO: move set navigationItem title here
+
 				self.show(content: self.makeResultContent(for: event))
 			}
 			.store(in: &subscriptions)

diff --git a/NOICommunity/NewsFeature/Coordinators/NewsCoordinator.swift b/NOICommunity/NewsFeature/Coordinators/NewsCoordinator.swift
@@ -60,7 +60,8 @@ private extension NewsCoordinator {
 			pageVC.askQuestionActionHandler = { [weak self] in
 				self?.showAskAQuestion(for: $0)
 			}
-
+
+			// TODO: move set navigationItem title here
 			pageVC.navigationItem.title = localizedValue(
 				from: news.languageToDetails
 			)?