Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CSS classes to trigger element when popup is opened/closed #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenmyhre
Copy link

No description provided.

@graffic
Copy link
Contributor

graffic commented Apr 2, 2015

I'd say it is better if the scope has isOpen so you can use ng-class later and use whatever classes you want.

IMHO Hard coded classes don't mix well with different code bases.

@stevenmyhre
Copy link
Author

That is a good point @graffic, but the directive currently doesn't have an isolate scope, so it would potentially override other isOpen scope variables due to prototypical scope inheritance, causing a similar issue. The CSS class was a quick and easy way to solve my problem, though I'm open to other options if they are viable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants