Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add binary generation threat #1433

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jan 27, 2025

Please take a look:

@nodejs/tsc @nodejs/build @nodejs/releasers @nodejs/security @nodejs/docker

cc: @nodejs/security-wg

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentGoderre
Copy link
Member

There is the supply chain vector as well where the tooling for generating the binaries can be compromised outside CI pipeline and brought in via a trusted source.

@RafaelGSS
Copy link
Member Author

There is the supply chain vector as well where the tooling for generating the binaries can be compromised outside CI pipeline and brought in via a trusted source.

I think that still falls in the nodejs/node resource, won't it?

@LaurentGoderre
Copy link
Member

Yep!

@ttshivers
Copy link
Member

Is it worth including https://github.com/nodejs/unofficial-builds which we use for the alpine docker images?

MAINTAINERS_THREAT_MODEL.md Show resolved Hide resolved
MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has any consideration been given to the website now recommending ways of installing Node.js outside of the project's control (e.g. nvm, fnm) but are the default options if visiting the website?

I also don't see the nodejs/nodejs.org GH repo which is where the download links/blog posts are published. This is separate from Vercel, where the website is deployed.

MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
@RafaelGSS
Copy link
Member Author

Has any consideration been given to the website now recommending ways of installing Node.js outside of the project's control (e.g. nvm, fnm) but are the default options if visiting the website?

I also don't see the nodejs/nodejs.org GH repo which is where the download links/blog posts are published. This is separate from Vercel, where the website is deployed.

We discussed it in the last security wg meeting and we'll include nodejs.org yes. I'll do it right after this PR lands.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typographic suggestions - this looks like a good addition overall. I'll try and go through it in a bit more detail to see if I can think of anything else too.

(Also, primarily as a note to self when I come back [here])https://github.com/nodejs/security-wg/blob/add-more-threads-to-maintainers-model/MAINTAINERS_THREAT_MODEL.md) is the rendered version from the PR branch)

MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
MAINTAINERS_THREAT_MODEL.md Outdated Show resolved Hide resolved
RafaelGSS and others added 3 commits February 4, 2025 10:12
@RafaelGSS RafaelGSS merged commit 58c5dbd into main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.