fix: handle the potential absence of events #7091
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
canerakdas
approved these changes
Oct 6, 2024
ovflowd
reviewed
Oct 6, 2024
| @@ -12,7 +12,7 @@ import styles from './calendar.module.css'; | |||
| type GroupedEntries = Record<string, Array<CalendarEvent>>; | |||
|
|
|||
| const UpcomingMeetings: FC = async () => { | |||
| const events = await getCalendarEvents(CALENDAR_NODEJS_ID); | |||
| const events = (await getCalendarEvents(CALENDAR_NODEJS_ID)) ?? []; | |||
There was a problem hiding this comment.
Instead of this, could you update the getCalendarEvents function to handle the undefined scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7090
Validation
Open http://localhost:3000/en/about/get-involved/events locally and see no errors. CI for this PR should now also pass.
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.